Skip to content

twister: Add missing failure reason in Robot test runner #97261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

twister: Add missing failure reason in Robot test runner #97261

merged 1 commit into from
Oct 9, 2025

Conversation

m-torhan
Copy link
Contributor

@m-torhan m-torhan commented Oct 9, 2025

When twister tests are executed using Renode and Robot framework and the Renode process fails, the python script also fails and no further tests are executed.

Error:

ERROR   - Robot test failure: _ for _
ERROR   - General exception: can only concatenate str (not "NoneType") to str
Traceback (most recent call last):
  File "/zephyr/scripts/pylib/twister/twisterlib/runner.py", line 2060, in pipeline_mgr
    return self.process_tasks(processing_queue, processing_ready, lock, results)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/zephyr/scripts/pylib/twister/twisterlib/runner.py", line 2043, in process_tasks
    pb.process(processing_queue, processing_ready, task, lock, results)
  File "/zephyr/scripts/pylib/twister/twisterlib/runner.py", line 1161, in process
    self.report_out(results)
  File "/zephyr/scripts/pylib/twister/twisterlib/runner.py", line 1553, in report_out
    status += " " + instance.reason
              ~~~~^~~~~~~~~~~~~~~~~
TypeError: can only concatenate str (not "NoneType") to str

ERROR   - Process 1541 failed, aborting execution

This PR fixes this behavior by simply adding failure reason when executed Renode process fails.

Output with the fix:

INFO    - 1/8 _  _              FAILED Exited with 1 (renode 3.159s <zephyr>)
ERROR   - see: /_/handler.log
... further tests are executed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2025

Hello @m-torhan, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@m-torhan
twister: scripts: add missing failure reason in Robot test runner
1346b8f 
Add failure reason with return code when Renode process fails

Signed-off-by: Maciej Torhan <[email protected]>
@zephyrbot zephyrbot added area: Twister Twister size: XS A PR changing only a single line of code labels Oct 9, 2025
@m-torhan m-torhan force-pushed the fix-twister-robot-harness branch from 6517935 to 1346b8f Compare October 9, 2025 09:29
@nashif nashif added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Oct 9, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cfriedt cfriedt merged commit 12d21df into zephyrproject-rtos:main Oct 9, 2025
49 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2025

Hi @m-torhan!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nashif nashif nashif approved these changes

@hakehuang hakehuang hakehuang approved these changes

@gchwier gchwier Awaiting requested review from gchwier

@golowanow golowanow Awaiting requested review from golowanow

@KamilxPaszkiet KamilxPaszkiet Awaiting requested review from KamilxPaszkiet

@LukaszMrugala LukaszMrugala Awaiting requested review from LukaszMrugala

@PerMac PerMac Awaiting requested review from PerMac

Assignees

@nashif nashif

Labels

area: Twister Twister size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@m-torhan @nashif @hakehuang @cfriedt @zephyrbot